Separate thread for cancellation tasks #1335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces separate thread specifically for the cancellation tasks. By doing so we may speed up final callback execution as task won't wait for its turn in the main busy queue and instead will be executed on the separate usually free thread. This is a quite bold move as we always allocate one additional thread regardless of user-specified total threads number. Relates-To: OLPSUP-17825 Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces separate thread specifically for the cancellation
tasks. By doing so we may speed up final callback execution as task
won't wait for its turn in the main busy queue and instead will be
executed on the separate usually free thread.
This is a quite bold move as we always allocate one additional thread
regardless of user-specified total threads number.
Relates-To: OLPSUP-17825
Signed-off-by: Andrey Kashcheev ext-andrey.kashcheev@here.com